CI: Install Android NDK r23c explicitly #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
akien-mga
commented
Nov 20, 2023
Comment on lines
-111
to
-115
| - name: Linux dependencies | ||
| if: ${{ matrix.platform == 'linux' }} | ||
| run: | | ||
| sudo apt-get update -qq | ||
| sudo apt-get install -qqq build-essential pkg-config |
There was a problem hiding this comment.
That seemed to do nothing, those are already installed.
akien-mga
force-pushed
the
ci-android-ndk-r23c
branch
2 times, most recently
from
c135fbc
to
079b6e2
Compare
akien-mga
commented
Nov 20, 2023
| @@ -65,7 +65,7 @@ jobs: | |||
| platform: android | |||
| artifact-name: godot-cpp-android-arm64-release | |||
| artifact-path: bin/libgodot-cpp.android.template_release.arm64.a | |||
| flags: ANDROID_NDK_ROOT=$ANDROID_NDK_LATEST_HOME arch=arm64 | |||
There was a problem hiding this comment.
This was unused, and wrong.
akien-mga
force-pushed
the
ci-android-ndk-r23c
branch
from
079b6e2
to
48387d4
Compare
akien-mga
force-pushed
the
ci-android-ndk-r23c
branch
from
48387d4
to
bab89e8
Compare
It has just been removed from the Ubuntu 20.04 default install, breaking our CI setup. Also, sets Emscripten version to 3.1.39, as done upstream. Newer versions actually break dynamic library support.
akien-mga
force-pushed
the
ci-android-ndk-r23c
branch
from
bab89e8
to
eea33b4
Compare
|
Cherry-picking to 4.1 in #1373 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has just been removed from the Ubuntu 20.04 default install, breaking our CI setup.
Also, sets Emscripten version to 3.1.39, as done upstream.
Newer versions actually break dynamic library support.