[SCons] Split targets.py, apply flags from tools
#1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
added
enhancement
Faless
force-pushed
the
build/targets_no_more
branch
from
d5a27cb
to
c699040
Compare
Faless
force-pushed
the
build/targets_no_more
branch
2 times, most recently
from
40d1355
to
3bcf019
Compare
Faless
changed the title
targets.py, only apply flags for default platformstargets.py, apply flags from tools
Split `targets` tool logic, moving all the compiler-specific flags to a new `common_compiler_flags.py` file, and everything else (CPPDEFINES, optimize option logic, dev build logic, etc) to the `godotcpp` tool. The default tools now apply the common compiler flags by importing the file and explicitly calling `configure`.
Faless
force-pushed
the
build/targets_no_more
branch
from
3bcf019
to
16df4bf
Compare
dsnopek
approved these changes
Feb 16, 2024
|
Cherry-picked for 4.2 in PR #1410 |
|
Cherry-picked for 4.1 in PR #1411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
targetstool logic, moving all the compiler-specific flags to a newcommon_compiler_flags.pyfile, and everything else (CPPDEFINES, optimize option logic, dev build logic, etc) to thegodotcpptool.The default tools now apply the common compiler flags by importing the file and explicitly calling
configure.See also: #1380
And from #1391 (comment)