Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load new script_instance_create3 GDExtension interface function #1397

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Mar 1, 2024

This depends on this Godot PR godotengine/godot#89055

Keeping as a draft, until that PR is merged.

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Mar 1, 2024
@dsnopek dsnopek added this to the 4.x milestone Mar 1, 2024
@dsnopek dsnopek requested a review from a team as a code owner March 1, 2024 17:04
@dsnopek dsnopek marked this pull request as draft March 1, 2024 17:04
@AThousandShips AThousandShips added waiting for Godot This issue needs a Godot Engine improvement to be solved and removed waiting for Godot This issue needs a Godot Engine improvement to be solved labels Mar 1, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and passes!

@dsnopek dsnopek marked this pull request as ready for review March 14, 2024 15:00
@dsnopek dsnopek merged commit ec16629 into godotengine:master Mar 14, 2024
12 checks passed
@dsnopek
Copy link
Collaborator Author

dsnopek commented Mar 14, 2024

Thanks!

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants