Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Math] Add is_finite methods #1436

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

AThousandShips
Copy link
Member

Did a minor sweep for these, there are some other things to carry over and some style improvements, but the exact changes might be more disruptive than these additions so leaving them for a future set of changes (some are also exclusive to later versions so keeping this one minimal to begin with)

@AThousandShips AThousandShips added enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation cherrypick:4.1 cherrypick:4.2 labels Apr 11, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 11, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner April 11, 2024 08:41
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek dsnopek merged commit 61450b3 into godotengine:master Apr 24, 2024
12 checks passed
@AThousandShips AThousandShips deleted the math_update branch April 24, 2024 19:55
@dsnopek
Copy link
Collaborator

dsnopek commented May 17, 2024

Cherry-picked for 4.2 in PR #1465

@dsnopek
Copy link
Collaborator

dsnopek commented May 17, 2024

Cherry-picked for 4.1 in PR #1466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_finite function missing from Basis, Vector2, Vector3, etc.(about 11 classes should have it)
3 participants