Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PropertyInfo to use hint/usage default constants #1440

Merged

Conversation

Naros
Copy link
Contributor

@Naros Naros commented Apr 16, 2024

This seems to stem from the old property usage flags before they were adjusted in 2022. It's probably just best to init the value using the PROPERTY_USAGE_DEFAULT to avoid this in the future.

@Naros Naros requested a review from a team as a code owner April 16, 2024 04:03
@AThousandShips AThousandShips added bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation labels Apr 16, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 16, 2024
@Naros Naros force-pushed the propertyinfo-wrong-usage-init-value branch from 601fdc1 to e160966 Compare April 16, 2024 11:25
@Naros Naros changed the title Fix incorrect PropertyInfo usage default Fix PropertyInfo to use hint/usage default constants Apr 16, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsnopek dsnopek merged commit ad307e4 into godotengine:master Apr 17, 2024
12 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Apr 17, 2024

Thanks!

@dsnopek
Copy link
Collaborator

dsnopek commented Apr 17, 2024

Cherry-picked for 4.1 in PR #1441

@dsnopek
Copy link
Collaborator

dsnopek commented Apr 17, 2024

Cherry-picked for 4.2 in PR #1442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants