Allow forwarding from ClassDB to ClassDBSingleton to support enumerations
#1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
dsnopek
force-pushed
the
classdb-enum-issue
branch
from
958c78d
to
e1b3b32
Compare
|
I tested it, work good. |
Naros
approved these changes
Apr 29, 2024
|
Thanks, Everyone, for the review and testing! ❤️ |
|
Cherry-picked for 4.2 in PR #1465 |
|
Cherry-picked for 4.1 in PR #1466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix godot-cpp when used with the
enumadded toClassDBin PR godotengine/godot-proposals#9526 (I tested using theextension_api.jsonfrom Godot built with that PR)Since Godot's CI uses godot-cpp for version N-1, this will need to be cherry-picked to the
4.2branch before the tests will be able to pass on that PR