Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark return value of get_class_static and get_parent_class_static as const. #1463

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented May 16, 2024

Refer to the commet in #1446 .

@Daylily-Zeleen Daylily-Zeleen requested a review from a team as a code owner May 16, 2024 18:08
@AThousandShips AThousandShips added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels May 17, 2024
@dsnopek dsnopek added cherrypick:4.1 cherrypick:4.2 and removed topic:buildsystem Related to the buildsystem or CI setup labels May 17, 2024
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great to me!

@dsnopek dsnopek added this to the 4.x milestone May 17, 2024
@dsnopek dsnopek merged commit e4a4d76 into godotengine:master May 17, 2024
12 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented May 17, 2024

Cherry-picked for 4.2 in PR #1465

@dsnopek
Copy link
Collaborator

dsnopek commented May 17, 2024

Cherry-picked for 4.1 in PR #1466

@Daylily-Zeleen Daylily-Zeleen deleted the daylily-zeleen/const_get_class_static branch May 18, 2024 08:40
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants