-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce p_
prefixes for arguments in binds
#1490
Conversation
My bad, missed this: Just making this an improvement |
Thanks! This makes sense to me: we use the The changes here look good in a quick skimming! This just needs a rebase after having merged PR #1485 |
e05cdb2
to
10d86e4
Compare
Some of the cases like Edit: Since these are actually generated with these arguments in the source with this change I'll fix it all |
ea2156d
to
0b703c3
Compare
I think we ultimately want to change all cases, so if there aren't any roadblocks to doing it now, let's do it! |
Realized a few binds include |
0b703c3
to
9e2771f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great to me :-)
Cherry-picked for 4.2 in PR #1527 |
Cherry-picked for 4.1 in PR #1529 |
Improves general readability of generated code and prevents potential collisions