Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting Godot version to run the tests with #1493

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Jun 14, 2024

Allow selecting the Godot version to run the tests with on CI.

@dsnopek dsnopek added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Jun 14, 2024
@dsnopek dsnopek added this to the 4.x milestone Jun 14, 2024
@dsnopek dsnopek requested a review from a team as a code owner June 14, 2024 16:22
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but the code looks right and useful

@dsnopek dsnopek marked this pull request as draft June 14, 2024 16:26
@dsnopek dsnopek marked this pull request as ready for review June 14, 2024 16:40
@dsnopek dsnopek changed the title [DRAFT] Allow selecting Godot version to run the tests with Allow selecting Godot version to run the tests with Jun 14, 2024
@dsnopek
Copy link
Collaborator Author

dsnopek commented Jun 14, 2024

Taking this out of draft because this PR and the 4.2 version are working! I'm really surprised this worked on my first try - I was expecting to have to tweak it and push a bunch of times before they both passed, but I guess I got lucky today :-)

@dsnopek dsnopek merged commit 8cdd56e into godotengine:master Jun 14, 2024
12 checks passed
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants