Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update macOS workers to macos-latest #1496

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[CI] Update macOS workers to macos-latest #1496

merged 1 commit into from
Jun 18, 2024

Conversation

Faless
Copy link
Contributor

@Faless Faless commented Jun 18, 2024 •
edited
Loading

GitHub actions no longer allow macos-11 runners.

See https://github.com/godotengine/godot-cpp/actions/runs/9551620476

@Faless Faless added bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup labels Jun 18, 2024
@Faless Faless requested a review from a team as a code owner June 18, 2024 13:39
@dsnopek
Copy link
Collaborator

dsnopek commented Jun 18, 2024

Thanks!

However, looking at Godot's CI, it's using macos-latest. Is there a reason we shouldn't do the same in godot-cpp?

@adamscott
Copy link
Member

Is there a reason we shouldn't do the same in godot-cpp?

I don't think so, I suggest that this PR sets the builder to macos-latest.

@Faless
Copy link
Contributor Author

Faless commented Jun 18, 2024

However, looking at Godot's CI, it's using macos-latest. Is there a reason we shouldn't do the same in godot-cpp?

Updated to use macos-latest

@Faless
[CI] Update macOS workers to macos-latest
2dd8917 
GitHub actions no longer allow `macos-11` runners
@Faless Faless changed the title [CI] Update macOS workers to macos-12 [CI] Update macOS workers to macos-latest Jun 18, 2024
dsnopek
dsnopek approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek dsnopek merged commit 068e930 into godotengine:master Jun 18, 2024
12 checks passed
@dsnopek dsnopek mentioned this pull request Jun 18, 2024
Merged
@Faless Faless deleted the ci/fix-macos branch June 18, 2024 20:02
@dsnopek
Copy link
Collaborator

dsnopek commented Jul 17, 2024

Cherry-picked for 4.2 in PR #1527

@dsnopek
Copy link
Collaborator

dsnopek commented Jul 17, 2024

Cherry-picked for 4.1 in PR #1529

@dsnopek dsnopek mentioned this pull request Jul 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug cherrypick:4.0 topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Faless @dsnopek @adamscott