Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing type info for PackedVector4Array #1546

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

aaronfranke
Copy link
Member

This was accidentally missed when PackedVector4Array was added to godot-cpp: #1456

Without this PR, it is not possible to bind methods using PackedVector4Array with ClassDB::bind_method.

4.3 milestone because this is a vital bugfix for a new 4.3 feature and it would be a shame to release 4.3 without this.

@aaronfranke aaronfranke added the bug This has been identified as a bug label Aug 11, 2024
@aaronfranke aaronfranke added this to the 4.3 milestone Aug 11, 2024
@aaronfranke aaronfranke requested a review from a team as a code owner August 11, 2024 04:24
Copy link
Contributor

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice last minute catch 👍

Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek dsnopek merged commit 9b98377 into godotengine:master Aug 11, 2024
12 checks passed
@aaronfranke aaronfranke deleted the fix-vec4arr branch August 11, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants