Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Integrate cache_limit from main repo #1671

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Dec 12, 2024

Code brought over virtually verbatim from the main repo where relevant. This will allow the main repo to utilize caching for godot-cpp in a way that can be safely constrained, as well as constraining caching for this repo (though it will never reach that new limit in practice)

@Repiteo Repiteo added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Dec 12, 2024
@Repiteo Repiteo requested review from a team as code owners December 12, 2024 23:50
Copy link
Contributor

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably a bit late to comment on the PR, since I'm guessing Godot upstream has the same (or similar) code merged already. Feel free to close any that aren't up for discussion anymore.

tools/godotcpp.py Outdated Show resolved Hide resolved
tools/godotcpp.py Show resolved Hide resolved
tools/godotcpp.py Outdated Show resolved Hide resolved
tools/godotcpp.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants