Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing class methods #296

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Add missing class methods #296

merged 1 commit into from
Aug 5, 2019

Conversation

lupoDharkael
Copy link
Contributor

Updated version of #216

@2shady4u
Copy link
Contributor

I'm afraid you'll have to reformat some things...
The Clang format rules can be pretty strict 😄

2shady4u
2shady4u suggested changes May 22, 2019
View reviewed changes
Copy link
Contributor

@2shady4u 2shady4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes are required to obey the Clang formatting rules, otherwise the Static Check of Travis CI fails.

include/core/Array.hpp Outdated Show resolved Hide resolved
src/core/Array.cpp Outdated Show resolved Hide resolved
src/core/Array.cpp Outdated Show resolved Hide resolved
src/core/NodePath.cpp Outdated Show resolved Hide resolved
@lupoDharkael
Copy link
Contributor Author

yes, I know it still fails. I was waiting for the tests to finish before checking again. I'm fixing the other format errors now.

@lupoDharkael
Copy link
Contributor Author

It is passing CI now. Thanks @2shady4u !

@BastiaanOlij BastiaanOlij added the enhancement This is an enhancement on the current functionality label Jun 15, 2019
karroffel
karroffel reviewed Jun 15, 2019
View reviewed changes
src/core/Array.cpp Outdated Show resolved Hide resolved
@2shady4u
Copy link
Contributor

2shady4u commented Aug 4, 2019

@lupoDharkael any update on this?

@lupoDharkael
Copy link
Contributor Author

I've made the changes requested by @karroffel
CI fails because of network stuff.

@karroffel
Copy link
Contributor

Fixed CI, thanks!

@karroffel karroffel merged commit c2ec46f into godotengine:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karroffel karroffel karroffel left review comments

@2shady4u 2shady4u 2shady4u requested changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lupoDharkael @2shady4u @karroffel @BastiaanOlij