Fix godot-cpp types registration #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A initialization bug was causing the registration to occur prior to a key required field being set (see godotengine#394 (comment) for more details). Fixes godotengine#394
|
Looks like the exact same issue I had with the bindings being queried too early, notice how they are in the same place you moved this code to. Seems like a solid fix to me. |
|
I'm all for merging this if someone else can verify it works. I've not experienced the problem mentioned myself but I haven't used multiple gdnative modules together for awhile now. |
@BastiaanOlij I validated the fix! I was running into a similar error as mentioned in #394, which this fix resolves. |
|
Let's merge it then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A initialization bug was causing the registration to occur prior to a key required field being set (see #394 (comment) for more details).
Fixes #394