Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need to use GODOT_SUBCLASS #454

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Remove the need to use GODOT_SUBCLASS #454

merged 1 commit into from
Dec 8, 2020

Conversation

Zylann
Copy link
Collaborator

@Zylann Zylann commented Sep 12, 2020 •
edited
Loading

So far, if you make a custom class, you had to use the GODOT_CLASS macro on top of it. But then if you make a custom class inheriting another custom class, you had to use GODOT_SUBCLASS.

This PR removes the difference, now you should be able to use GODOT_CLASS for any custom class.
GODOT_SUBCLASS remains defined for compatibility.

@Zylann Zylann added the enhancement This is an enhancement on the current functionality label Sep 12, 2020
BastiaanOlij
BastiaanOlij approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to find time to test this but looking at the code this seems like a good improvement.

@Zylann Zylann merged commit 1ec4526 into godotengine:master Dec 8, 2020
@follower follower mentioned this pull request Mar 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zylann @BastiaanOlij