Generate bindings if they are not found #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a primitive check to figure out if bindings should be generated or not.
It checks if
src/gen/Object.cppexists. If it isn't found, then bindings will get generated.The
generate_bindingsoption is an enumeration that can be given the following values:true, oryes: will generate bindingsno: will not generate bindingsauto: will detect presence of bindings. This is now the default value, so less users will forget to do this step.This check does not detect if bindings should be re-generated. So if you update the library with Git for example, you still have to tell it explicitely, or clear the generated folder before building.