Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Variant destructor in operator= to prevent a memory leak #666

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

BimDav
Copy link

@BimDav BimDav commented Dec 3, 2021

This is to prevent memory leaks in the present implementation of Variant operator= in GDNative (see #647, #643)

Bugsquad edit:

@BimDav
Copy link
Author

BimDav commented Dec 3, 2021

This approach was preferred to the one started in #648 because it does not need a change in godot-headers and other operator= function in godot-cpp are implemented this way.

@akien-mga akien-mga added bug This has been identified as a bug cherrypick:3.4 labels Dec 3, 2021
@akien-mga akien-mga merged commit 4efceef into godotengine:3.x Dec 3, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga added this to the 3.5 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants