Fix Ref leak when using Godot getters #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
suggested changes
Jan 25, 2018
binding_generator.py
Outdated
| @@ -346,7 +346,7 @@ def generate_class_implementation(icalls, used_classes, c): | |||
| if is_enum(method["return_type"]): | |||
| return_statement += "return (" + remove_enum_prefix(method["return_type"]) + ") " | |||
| elif is_reference_type(method["return_type"]): | |||
| return_statement += "return Ref<" + strip_name(method["return_type"]) + ">("; | |||
| return_statement += "return Ref<" + strip_name(method["return_type"]) + ">::__internal_constructor("; | |||
There was a problem hiding this comment.
You shouldn't use tabs here 😛
There was a problem hiding this comment.
Duh, I edited this file with QtCreator, which is configured with tabs because Godot AND the CppBindings use tabs...
Zylann
force-pushed
the
fix_ref_return_leak
branch
from
a029bd1
to
ac0679e
Compare
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85