Update C# signal documentation #6110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhilbrunner
requested changes
Aug 26, 2022
There was a problem hiding this comment.
The changes to the classes/*.rst files need to be made to the class doc XMLs in the main repo instead and removed from these, as the RSTs are autogenerated and overwritten periodically, so these changes would get lost.
Everything else looks good at first glance.
|
Oops, you are right, I used a regex to find all instances and missed that I was editing the class reference 🙃 Edit: Extracted to godotengine/godot#64930 |
Updates C# signal documentation and code examples to the new API in 4.0
raulsntos
force-pushed
the
dotnet/new-signals
branch
from
3d3bb13 to
3b36a94
Compare
mhilbrunner
approved these changes
Aug 26, 2022
|
Great, thanks for working on 4.0 docs! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates C# signal documentation and code examples to the new API in 4.0.