Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation pages on 2D and 3D antialiasing #6267

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 6, 2022

Images on the new pages were generated using https://github.com/Calinou/godot-antialiasing-comparison.

Some of this information is relevant for 3.x, so this PR could be remade for the 3.6 branch and cherry-picked to 3.5 (with mentions of alpha to coverage, TAA and 3D resolution scaling removed).

@Calinou Calinou added enhancement content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features topic:rendering labels Oct 6, 2022
@Calinou Calinou force-pushed the add-antialiasing-docs branch 2 times, most recently from b6daea3 to 1841dc5 Compare October 6, 2022 13:35
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

One thing I noticed but couldn't comment on is that the TAA photo looks like there is no antialising (in many places the aliasing is worse than with no-antialising). It looks significantly worse than FXAA in these screenshots. How are you capturing the images for it? Are you using something automated that saves the first frame?

about/list_of_features.rst Outdated Show resolved Hide resolved
@Calinou
Copy link
Member Author

Calinou commented Oct 6, 2022

Are you using something automated that saves the first frame?

The demo project waits for 30 frames to be rendered before taking the TAA screenshot. It's strange that it looks bad, but maybe this is due to the low input resolution (348×348, so the image can be displayed at a pixel-perfect size in the online docs on desktop).

@Calinou Calinou force-pushed the add-antialiasing-docs branch from 1841dc5 to 045d6f9 Compare October 8, 2022 16:04
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, didn't spot anything (aside from the above discussion).
Feel free to merge once you have figured out what to do with that :P

Good work!

Copy link
Contributor

@snailrhymer snailrhymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little changes, and highlighted some points where terminology wasn't clear to me (intermediate dev, very limited exerience with rendering).

tutorials/2d/2d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/2d/2d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/3d/3d_rendering_limitations.rst Show resolved Hide resolved
tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/2d/2d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the add-antialiasing-docs branch from 045d6f9 to 8c0164f Compare October 19, 2022 16:15
@clayjohn
Copy link
Member

@Calinou Looks like you forgot to remove the FSR reference under anti-aliasing, after that it should be good!

@clayjohn clayjohn self-requested a review October 19, 2022 18:57
tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/2d/2d_antialiasing.rst Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the add-antialiasing-docs branch 3 times, most recently from cd0c8f9 to 587948f Compare October 21, 2022 23:34
@Calinou
Copy link
Member Author

Calinou commented Oct 21, 2022

@Calinou Looks like you forgot to remove the FSR reference under anti-aliasing, after that it should be good!

Done 🙂

I've created a documentation page dedicated to 3D resolution scaling: #6331

@mhilbrunner
Copy link
Member

Want to convert the pngs to webps? :) Otherwise this looks mergeable

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting very close to being ready to merge!

tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the add-antialiasing-docs branch from 587948f to a68d47c Compare October 23, 2022 17:42
@Calinou Calinou force-pushed the add-antialiasing-docs branch from a68d47c to 048f5e5 Compare October 23, 2022 17:48
@Calinou
Copy link
Member Author

Calinou commented Oct 23, 2022

Want to convert the pngs to webps? :) Otherwise this looks mergeable

Done. For reference, I used parallel cwebp -z 9 {} {.}.webp ::: 3d_antialiasing_*.png for lossless compression with the smallest possible file size. New images are on average 30% smaller compared to their PNG equivalents, but with the same quality.

@akien-mga akien-mga merged commit 87c99fe into godotengine:master Nov 17, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features enhancement topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants