-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation pages on 2D and 3D antialiasing #6267
Conversation
b6daea3
to
1841dc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
One thing I noticed but couldn't comment on is that the TAA photo looks like there is no antialising (in many places the aliasing is worse than with no-antialising). It looks significantly worse than FXAA in these screenshots. How are you capturing the images for it? Are you using something automated that saves the first frame?
The demo project waits for 30 frames to be rendered before taking the TAA screenshot. It's strange that it looks bad, but maybe this is due to the low input resolution (348×348, so the image can be displayed at a pixel-perfect size in the online docs on desktop). |
1841dc5
to
045d6f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, didn't spot anything (aside from the above discussion).
Feel free to merge once you have figured out what to do with that :P
Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some little changes, and highlighted some points where terminology wasn't clear to me (intermediate dev, very limited exerience with rendering).
045d6f9
to
8c0164f
Compare
@Calinou Looks like you forgot to remove the FSR reference under anti-aliasing, after that it should be good! |
cd0c8f9
to
587948f
Compare
Want to convert the pngs to webps? :) Otherwise this looks mergeable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting very close to being ready to merge!
587948f
to
a68d47c
Compare
a68d47c
to
048f5e5
Compare
Done. For reference, I used |
Thanks! |
Images on the new pages were generated using https://github.com/Calinou/godot-antialiasing-comparison.
Some of this information is relevant for 3.x, so this PR could be remade for the
3.6
branch and cherry-picked to3.5
(with mentions of alpha to coverage, TAA and 3D resolution scaling removed).