Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 3D lights and shadows documentation for 4.0 #6355

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Update 3D lights and shadows documentation for 4.0 #6355

merged 1 commit into from
Mar 6, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 2, 2022 •
edited
Loading

No description provided.

@Calinou Calinou mentioned this pull request Nov 2, 2022
Open
41 tasks
skyace65
skyace65 requested changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks very good, just needs a few changes.

tutorials/3d/lights_and_shadows.rst Outdated Show resolved Hide resolved
tutorials/3d/lights_and_shadows.rst Outdated Show resolved Hide resolved
tutorials/3d/lights_and_shadows.rst Show resolved Hide resolved
@Calinou Calinou force-pushed the update-3d-lights-and-shadows-4.0 branch 2 times, most recently from 870eaca to 04c1722 Compare November 5, 2022 17:24
skyace65
skyace65 approved these changes Nov 6, 2022
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@Calinou Calinou force-pushed the update-3d-lights-and-shadows-4.0 branch from 04c1722 to d4b5f1f Compare November 24, 2022 22:38
@skyace65 skyace65 added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Jan 13, 2023
@Calinou Calinou force-pushed the update-3d-lights-and-shadows-4.0 branch from d4b5f1f to f89ffb2 Compare February 24, 2023 00:38
@Calinou Calinou marked this pull request as ready for review February 24, 2023 00:38
@Calinou Calinou force-pushed the update-3d-lights-and-shadows-4.0 branch 3 times, most recently from e4cd868 to 4dcbe85 Compare February 24, 2023 02:03
clayjohn
clayjohn reviewed Feb 24, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Just a few comments. This is nearly ready to merge

tutorials/3d/lights_and_shadows.rst Outdated Show resolved Hide resolved
tutorials/3d/lights_and_shadows.rst Outdated Show resolved Hide resolved
tutorials/3d/lights_and_shadows.rst Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the update-3d-lights-and-shadows-4.0 branch 4 times, most recently from 0da1588 to bc3f3ac Compare February 27, 2023 19:21
clayjohn
clayjohn approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks good to me

@Calinou Calinou force-pushed the update-3d-lights-and-shadows-4.0 branch from bc3f3ac to ccb6693 Compare February 28, 2023 00:07
@akien-mga
Copy link
Member

akien-mga commented Mar 6, 2023 •
edited
Loading

Can be rebased to fix warnings now that the page on decals was merged.

Edit: Pushed myself.

@akien-mga akien-mga force-pushed the update-3d-lights-and-shadows-4.0 branch 2 times, most recently from eaae04b to 9189aa3 Compare March 6, 2023 10:47
@akien-mga akien-mga force-pushed the update-3d-lights-and-shadows-4.0 branch from 9189aa3 to 50b86d7 Compare March 6, 2023 10:55
@akien-mga akien-mga merged commit 1767222 into godotengine:master Mar 6, 2023
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the update-3d-lights-and-shadows-4.0 branch March 15, 2023 16:28
@tetrapod00 tetrapod00 mentioned this pull request Dec 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@skyace65 skyace65 skyace65 approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Calinou @akien-mga @mhilbrunner @skyace65 @clayjohn