Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document C# currently not being supported on Android, iOS and Web #7551

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Document C# currently not being supported on Android, iOS and Web #7551

merged 1 commit into from
Jul 4, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 23, 2023

@Calinou Calinou added enhancement topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.0 labels Jun 23, 2023
@paulloz
Copy link
Member

paulloz commented Jun 24, 2023

LGTM 🚀

raulsntos
raulsntos approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 🙂. The only thing that I'm worried about is having to find all these notes to remove them when we eventually add support for these platforms.

tutorials/scripting/c_sharp/c_sharp_basics.rst
Comment on lines +30 to +35
.. attention::

Projects written in C# using Godot 4.x currently cannot be exported to
Android, iOS and web platforms. To use C# on those platforms, use Godot 3
instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this was already mentioned in this page in the Current gotchas and known issues section but it's probably too easy to miss.

@skyace65 skyace65 merged commit 22b5c86 into godotengine:master Jul 4, 2023
@skyace65
Copy link
Contributor

skyace65 commented Jul 4, 2023

Thanks!

@AThousandShips AThousandShips mentioned this pull request Jul 28, 2023
Closed
mhilbrunner pushed a commit that referenced this pull request Aug 1, 2023
@skyace65 @mhilbrunner
Merge pull request #7551 from Calinou/csharp-export-limitations
04a4e3a 
Document C# currently not being supported on Android, iOS and Web
mhilbrunner pushed a commit that referenced this pull request Aug 1, 2023
@skyace65 @mhilbrunner
Merge pull request #7551 from Calinou/csharp-export-limitations
2f7c25e 
Document C# currently not being supported on Android, iOS and Web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyace65 skyace65 skyace65 approved these changes

@akien-mga akien-mga akien-mga approved these changes

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Calinou @paulloz @skyace65 @raulsntos @akien-mga @mhilbrunner