Bumping Java JDK to 17 for Latest Android Release #7968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest android sdkmanager requires java greater than 11. bumping the export tutorial version to java 17, the latest LTS version.
AThousandShips
added
enhancement
area:manual
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
|
My understanding based on comments made by m4gr3d in other PRs and issues is that Godot still needs to use JDK11. @m4gr3d is that still correct? |
|
If folks download the latest Android, per the export tutorial instructions,
Java 11 will not work, android sdkmanager will fail with a Java version
error msg.
I followed the command line only instructions (which I assume is the one
Godot devs would want since Androids ide is like 100 GB that is not
needed).
Everything works as expected in Godot 4.1 for both building the APK and
also wireless debuging on my device via the play scene on remote device
button in Godot with Java 17.
…On Wed, Sep 20, 2023, 9:52 PM Matthew ***@***.***> wrote:
My understanding based on comments made by m4gr3d in other PRs and issues
is that Godot still needs to use JDK11. @m4gr3d
<https://github.com/m4gr3d> is that still correct?
—
Reply to this email directly, view it on GitHub
<#7968 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFVKUIM3MS5PYUCH4ZNDN3X3OMWBANCNFSM6AAAAAA5AHCT6Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
akien-mga
changed the title
akien-mga
approved these changes
Oct 6, 2023
|
I'll be testing those changes today for validation. |
|
@m4gr3d Bump :) |
m4gr3d
approved these changes
Oct 17, 2023
skyace65
approved these changes
Oct 19, 2023
|
Thanks! |
|
@m4gr3d should this be cherrypicked for 4.1? |
mhilbrunner
pushed a commit
that referenced
this pull request
Nov 11, 2023
Bumping Java JDK to 17 for Latest Android Release
|
Cherry-picked to 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of android sdkmanager requires java greater than 11.
Bumping the link in the export to android tutorial to java 17, the latest LTS version
Fixes #7902