Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the note about disconnecting C# signals #8538

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Change the note about disconnecting C# signals #8538

merged 1 commit into from
Nov 29, 2023
+5 −5

Conversation

paulloz
Copy link
Member

@paulloz paulloz commented Nov 29, 2023

I'm not entirely sure about the formulation. Feel free to suggest edits. For context:

I saw we were talking about Reference on the page, which doesn't exist any more. I fixed that at the same time.

@raulsntos raulsntos added enhancement topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.0 cherrypick:4.1 cherrypick:4.2 labels Nov 29, 2023
raulsntos
raulsntos approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Thank you and sorry for letting this note be inaccurate for so long.

YuriSizov
YuriSizov approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've done it! LGTM

@mhilbrunner mhilbrunner merged commit b8a980f into godotengine:master Nov 29, 2023
1 check passed
@mhilbrunner
Copy link
Member

Thank you! Merged.

@paulloz paulloz deleted the signal-disconnect branch November 30, 2023 08:56
@31 31 mentioned this pull request Jan 22, 2024
Merged
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

@raulsntos raulsntos raulsntos approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.0 cherrypick:4.1 enhancement topic:dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulloz @mhilbrunner @raulsntos @YuriSizov