Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added xcode-select fix to iOS export page #8631

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

AdriaandeJongh
Copy link
Contributor

This PR adds a troubleshooting section to the export to iOS page, and a section about a iPhone SDK path error with a relatively simple fix.

tutorials/export/exporting_for_ios.rst Outdated Show resolved Hide resolved
tutorials/export/exporting_for_ios.rst Outdated Show resolved Hide resolved
tutorials/export/exporting_for_ios.rst Outdated Show resolved Hide resolved
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Dec 15, 2023
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits into one, see Pull request workflow.

@AdriaandeJongh
Copy link
Contributor Author

AdriaandeJongh commented Jan 8, 2024

Please squash the commits into one, see Pull request workflow.

sorry – I really messed up my GIT branches to the point where I have no idea how to fix it! The doc you link to doesn't describe the workflow for an accidental merge with master. Is there a way I could redo / recreate this branch, perhaps?

@AdriaandeJongh
Copy link
Contributor Author

A hard reset to my original commit and a force push did the trick! That should probably be in the docs as well?

@mhilbrunner mhilbrunner merged commit 8f7879b into godotengine:master Jan 13, 2024
1 check passed
@mhilbrunner
Copy link
Member

Squashed and merged. Thanks!

mhilbrunner added a commit that referenced this pull request Jan 25, 2024
* Added xcode-select fix to iOS export page

---------

Co-authored-by: Max Hilbrunner <mhilbrunner@users.noreply.github.com>
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants