Fixed typo in pr_workflow.rst #8671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
requested changes
Dec 24, 2023
skyace65
added
bug
area:contributing
Co-authored-by: Matthew <matthewehr@hotmail.com>
|
Hi, I committed your change. I see that the docs suggested to keep changes to a single commit when possible, but I'm not sure if it's possible to do that via GitHub's online editor. If you want me to delete and re-submit the PR as a single commit let me know. |
|
It's okay in this case, but in the future please use the computer setup, just editing from the web interface is very limited 🙂 |
skyace65
approved these changes
Dec 27, 2023
|
I've done a squash and merge for this PR so it's only 1 commit, but in the future I'd highly recommend getting setup with a proper editor on your computer for using Git. If you don't know anything about Git we have a guide in the Godot docs here. Also congrats on your first merged PR! |
mhilbrunner
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Fixed typo in pr_workflow.rst
|
Cherry-picked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.