Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TTS page to mention Text to Speech project setting #8728

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Update TTS page to mention Text to Speech project setting #8728

merged 1 commit into from
Jan 8, 2024

Conversation

nightblade9
Copy link
Contributor

Update TTS page to include information about the TTS project-level setting.
See: godotengine/godot#85613

tutorials/audio/text_to_speech.rst Outdated Show resolved Hide resolved
tutorials/audio/text_to_speech.rst Outdated Show resolved Hide resolved
tutorials/audio/text_to_speech.rst Outdated Show resolved Hide resolved
tutorials/audio/text_to_speech.rst Outdated Show resolved Hide resolved
@nightblade9
Copy link
Contributor Author

Thank you for the quick turn-around and review on this!

Am I supposed to squash and force-push my commits, or simply wait for a merge?

@skyace65
Copy link
Contributor

skyace65 commented Jan 7, 2024

Please keep your PR to one commit, if you don't know how to do that I can do a squash and merge in this repository and link you to our guide(engine repository does not have the option to squash and merge). I'm just leaving this PR open for a little in case anyone else wants to review it.

@nightblade9
Copy link
Contributor Author

Please keep your PR to one commit

Will squash/push when I get back to my dev machine, thanks for clarifying. Please let me know if there's anything else pending from me.

@mhilbrunner mhilbrunner added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.2 labels Jan 8, 2024
@mhilbrunner mhilbrunner merged commit afc8938 into godotengine:master Jan 8, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you! Merged.

@nightblade9
Copy link
Contributor Author

Thank you for the quick turn-around, much appreciated.

mhilbrunner added a commit that referenced this pull request Jan 25, 2024
Update TTS page to mention Text to Speech project setting
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants