Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SCons command line options for CCFLAGS, etc. to lowercase #8743

Merged

Conversation

akien-mga
Copy link
Member

Matching the changes in godotengine/godot#86964.

Shouldn't be cherry-picked, depends on the above PR.


Since it's the only mention in the docs, and it's for a very niche use case, I chose not to add a prominent warnings about the change of case in 4.3.

@YuriSizov YuriSizov added the area:contributing Issues and PRs related to the Contributing/Development section of the documentation label Jan 9, 2024
@AThousandShips AThousandShips added the waiting on PR merge PR's that can't be merged until a engine PR is merged first label Jan 9, 2024
@skyace65 skyace65 added this to the 4.3 milestone Jan 10, 2024
@skyace65 skyace65 removed the waiting on PR merge PR's that can't be merged until a engine PR is merged first label Feb 21, 2024
@skyace65 skyace65 merged commit 4f21f44 into godotengine:master Feb 23, 2024
1 check passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants