Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Internal rendering architecture for Godot 4.2 #8776

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Update Internal rendering architecture for Godot 4.2 #8776

merged 1 commit into from
Jan 20, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 15, 2024

No description provided.

@Calinou Calinou added enhancement area:contributing Issues and PRs related to the Contributing/Development section of the documentation cherrypick:4.2 labels Jan 15, 2024
@Calinou Calinou force-pushed the update-internal-rendering-architecture branch from 935da00 to 22fadd7 Compare January 15, 2024 17:37
@Calinou Calinou force-pushed the update-internal-rendering-architecture branch from 22fadd7 to 307650e Compare January 17, 2024 00:15
clayjohn
clayjohn approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@mhilbrunner mhilbrunner merged commit 0e05624 into godotengine:master Jan 20, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you! 🎉

mhilbrunner added a commit that referenced this pull request Jan 25, 2024
@mhilbrunner
Merge pull request #8776 from Calinou/update-internal-rendering-archi…
d0286df 
…tecture

Update Internal rendering architecture for Godot 4.2
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

@Calinou Calinou deleted the update-internal-rendering-architecture branch January 28, 2024 17:43
@mcendu
Copy link

mcendu commented Apr 11, 2024 •
edited
Loading

The cherry-pick need to be partially reverted as the link to the Vulkan RenderingDevice implementation is broken.

godot-docs/contributing/development/core_and_modules/internal_rendering_architecture.rst

Lines 275 to 279 in f0f255f

- `drivers/vulkan/rendering_device_driver_vulkan.cpp <https://github.com/godotengine/godot/blob/4.2/drivers/vulkan/rendering_device_driver_vulkan.cpp>`__
**Direct3D 12 RenderingDevice implementation:**
- `drivers/d3d12/rendering_device_driver_d3d12.cpp <https://github.com/godotengine/godot/blob/master/drivers/d3d12/rendering_device_driver_d3d12.cpp>`__

@skyace65
Copy link
Contributor

The link was fixed by #8977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@skyace65 skyace65 skyace65 approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Calinou @mhilbrunner @mcendu @skyace65 @clayjohn