Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spatial_shader.rst to delete outdated light shader usage #8818

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update spatial_shader.rst to delete outdated light shader usage #8818

merged 1 commit into from
Jan 24, 2024

Conversation

jsjtxietian
Copy link
Contributor

clayjohn
clayjohn approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole page needs to be overhauled. But that should be done in a separate PR. This is good for now!

@mhilbrunner mhilbrunner added bug topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.2 labels Jan 24, 2024
@mhilbrunner mhilbrunner merged commit 39346c8 into godotengine:master Jan 24, 2024
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks for contributing! 🎉

@jsjtxietian jsjtxietian deleted the patch-5 branch January 24, 2024 09:42
mhilbrunner added a commit that referenced this pull request Jan 25, 2024
@mhilbrunner
Merge pull request #8818 from jsjtxietian/patch-5
89eba76 
Update spatial_shader.rst to delete outdated light shader usage
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsjtxietian @mhilbrunner @clayjohn