-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "alt" with "opt" for macOS shortcuts #8932
Conversation
As a Mac user, I agree with this PR. The key is labeled as "option" on my keyboard. |
I couldn't find any references to a macOS If accepted, should this line in the Docs Writing Guidelines also be changed along to "On macOS, godot-docs/contributing/documentation/docs_writing_guidelines.rst Lines 499 to 500 in ec3426d
|
I think it would make more sense to just link to the shortcut page from there. |
I've updated this PR so the doc writing guidelines just link to the keyboard shortcut page. |
@skyace65 thanks for pointing this out and I see that we both ran into the same confusion! My only recommendation is to reorder the mac keys based on the order of the keyboard, so instead of |
Indeed, Apple seems to list Opt first: https://support.apple.com/en-us/HT201236 |
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and seems to make sense, formatting looks good, I did not check every shortcut and am also not often using a Mac though, so if someone using Mac as their daily driver could review, this would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not go through every shortcut, but as seen in my keyboard photo you can see that the keyboard does not say alt
but option
. So it looks good to me.
Merged! Thanks you. |
Cherry-picked to 4.2 in #9648. |
In the past Mac keyboards would have "alt" written on the option key in addition to "option", these days it's just "option". I'm using "Opt" instead of "Option" for these based on discussions with bruvzg in rocket chat. Closes #7959.