Unify C# naming notes and comments #9075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
added
enhancement
topic:dotnet
area:getting started
AThousandShips
approved these changes
Mar 10, 2024
|
Fixed. I've also added a period to the code comments in the first 3D game that I was copying from. |
raulsntos
approved these changes
Mar 10, 2024
mhilbrunner
approved these changes
Mar 10, 2024
|
Thank you! 🎉 |
|
Cherry-picked to 4.2 in #9648. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this because of discussion in #9048.
Currently there's a note in the first 2D game tutorial about naming, the first 3D game has comments in all of its code for signals, and the signals page in step by step has nothing. This PR makes it so all sections have a note and code comments. The notes are being used in addition to comments since comments can't be translated. Technically we could have the note just in the signals page, since you're supposed to read that before either of the first game tutorials, but I don't think we should assume people won't skim or skip around. Plus if someone's going through these pages over multiple days and not in one day it's good to have reminders.
Closes #9048.