Update gdscript_styleguide.rst - clarified sentence and grammar #9110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clarified the statement on "One statement per line" - Removed unclear sentence with incorrect grammar
|
Thank you for your patience :) this is confusing and complicated and the interface isn't always obvious |
AThousandShips
added
topic:gdscript
area:manual
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
dalexeev
reviewed
Mar 17, 2024
|
ready to submit with no other changes |
|
@AThousandShips @dalexeev |
dalexeev
approved these changes
Mar 21, 2024
|
@444B No, there are no suggestions. Please wait while a maintainer merges this. Thanks! |
mhilbrunner
approved these changes
Mar 21, 2024
|
Merged. Thanks and congrats on your first merged contribution! |
|
Thank you! |
mhilbrunner
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Update gdscript_styleguide.rst - clarified sentence and grammar - Clarified the statement on "One statement per line" - Removed unclear sentence with incorrect grammar --------- Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> (cherry picked from commit 3d44115)
|
Cherry-picked to 4.2 in #9648. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @AThousandShips for your patience :)
Correctly started from
masterbranch and not4.2