-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide instructions for resource change notifications in tools #9283
Provide instructions for resource change notifications in tools #9283
Conversation
Also: I know this is not strictly adhering to the guidelines when it comes to giving easy-to-understand examples, but honestly this is kind of an advanced issue so I feel there is a value in keeping it short? But feel free to suggest a different framing and I will update it. Most examples of resources I could think of would add a lot of complexity to the explanation because using a resource in a tool does not make sense that often. |
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Thanks @AThousandShips ! |
You missed several ones, please check all |
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Yea I just realized that as well while checking the diff. I did not expect github to collapse unresolved threads and not resolved ones. |
Also note that you can use the |
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stylewise this look great!
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Thanks! And congratulations on your first merged contribution! 🎉 |
I think I did another documentation thing before, but this is the first merge with code :D |
It wasn't registered at least, at least not on here |
Oh no, we missed a typo. Will fix that soon, but need to run rn |
GD.Print("My resource just changed!"); | ||
} | ||
|
||
Lastly, you should to disconnect the signal as the old resource being used and changed somewhere else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lastly, you should to disconnect the signal as the old resource being used and changed somewhere else | |
Lastly, remember to disconnect the signal as the old resource being used and changed somewhere else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay I am afraid this is going to need a new PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you can't update something already merged, but no worries, missed it too
(cherry picked from commit e6c8e51)
Cherry-picked to 4.2 in #9648. |
I have found this quite counter-intuitive, and was irritated by there being no guidance around this, so I wanted to create this enhancement.
Please double-check my c# Code, I do not use it personally and there will probably be mistakes.