Document QOA in importing audio samples #9319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
area:manual
AThousandShips
approved these changes
May 4, 2024
mhilbrunner
approved these changes
May 4, 2024
There was a problem hiding this comment.
LGTM (besides what ATS already noted).
For reference, this is the corresponding engine PR that added QOA: godotengine/godot#91014
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QOA compression is coming in version 4.3.
I generated 1 second of noise in Audacity to get the QOA file size.
Also did a small fix on the table: IMA-ADPCM is a format, not a mix rate.