Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Note from Constants #9407

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Remove Note from Constants #9407

merged 1 commit into from
Jun 5, 2024

Conversation

ceejbro
Copy link
Contributor

@ceejbro ceejbro commented May 21, 2024

From PR #71051

Documentation not updated to reflect deep read-only change to const Array and const Dictionary

Remove Note Section describing that Arrays and Dictionaries could be modified after declared constant when that is no longer the case.

PR #71051
Documentation not updated to reflect deep read-only change to const Array and const Dictionary
@AThousandShips AThousandShips requested a review from a team May 22, 2024 08:43
@dalexeev dalexeev added bug topic:gdscript area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 cherrypick:4.2 labels May 22, 2024
@dalexeev dalexeev added this to the 4.3 milestone May 22, 2024
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Constant packed arrays can still be modified, but this is a bug that will probably be fixed at some point. Constant objects (preloaded resources) can still be modified, but I don't think we need to emphasize that.

@skyace65 skyace65 removed this from the 4.3 milestone May 25, 2024
@skyace65 skyace65 merged commit 194685b into godotengine:master Jun 5, 2024
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Jun 5, 2024

Thanks! And congrats on your first merged PR!

@mhilbrunner
Copy link
Member

Cherry-picked to 4.2 in #9648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.1 topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants