Add smoothstep graphs #9489
Add smoothstep graphs #9489
Conversation
AThousandShips
added
enhancement
content:images
|
Just for clarity as it's not specified clearly in the OP, Malcolm is adding just images, no documentation changes, here because they are included in the documentation of the smoothstep function inside the main godot repo. I don't know if there is precedence for this. I don't know if this is the correct way to go about adding images in the class reference, especially seeing the way they are referenced? The images do provide a lot of context to the class reference. |
Malcolmnixon
force-pushed
the
smoothstep-graphs
branch
from
9bc9890
to
e633d03
Compare
|
I decided to merge the graphs into a single comparison image, which also includes showing the zero-range behavior. Additionally the graphs now show the area under the curve to better highlight the function response. |
|
IIRC this is fine and already done in other parts of the class reference. Please convert the PNG file to WebP (we're in the process of moving the docs repository over to WebP, see image creation guidelines). That the linked PR using this image (godotengine/godot#93149) does other stuff than just embedding the image makes it a bit harder to merge, as the main repo PR may get rejected. Please ping me if it gets another approval. |
…ith positive, zero, and negative ranges.
Malcolmnixon
force-pushed
the
smoothstep-graphs
branch
from
e633d03
to
379fea1
Compare
The image has been converted to WebP format. |
It might be better for this to go in first. If the main repository PR goes in then users trying to access the smoothstep documentation will get missing images. Pulling this in first shouldn't break anything - it'll just be available for use when the main repository merge goes through. |
|
That makes sense. Merging now to be safe |
This PR adds two graphs showing the behavior of the smoothstep function with positive and negative ranges.