-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commas before "but" throughout documentation #9582
Add commas before "but" throughout documentation #9582
Conversation
Looking through this, I am seeing a lot of cases that add a comma where it shouldn't. The general rule for english grammar is that you place a comma before "but" when it is being used to connect two independent clauses. When the "but" is not being used to connect two independent clauses, a comma should not be used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cases that I feel are either outright wrong or at minimum hurt the flow of the sentence, probably more amongst these but these are the to me clear ones
contributing/development/compiling/introduction_to_the_buildsystem.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
…stem.rst Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Definitely good call out @AThousandShips and @clayjohn . I got a little comma happy. I found a few others and had a question on one of them as i try to align. Let me know if you see anything else or if you want me to just close the PR. |
I'll take a look tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside of my review comments, all other changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Save for the cases suggested this looks good now
Thanks! |
In a few files opened, there were some blank strings at the end of lines that were auto cleaned up. I can remove these updates if you prefer them to stay.