Add commas before "but" throughout documentation #9582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking through this, I am seeing a lot of cases that add a comma where it shouldn't. The general rule for english grammar is that you place a comma before "but" when it is being used to connect two independent clauses. When the "but" is not being used to connect two independent clauses, a comma should not be used |
contributing/development/compiling/introduction_to_the_buildsystem.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
…stem.rst Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
russellsanborn
commented
Jul 9, 2024
russellsanborn
commented
Jul 9, 2024
russellsanborn
commented
Jul 9, 2024
russellsanborn
commented
Jul 9, 2024
russellsanborn
commented
Jul 9, 2024
|
Definitely good call out @AThousandShips and @clayjohn . I got a little comma happy. I found a few others and had a question on one of them as i try to align. Let me know if you see anything else or if you want me to just close the PR. |
|
I'll take a look tomorrow! |
Calinou
reviewed
Jul 27, 2024
AThousandShips
approved these changes
Jul 27, 2024
mhilbrunner
approved these changes
Aug 4, 2024
skyace65
approved these changes
Aug 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few files opened, there were some blank strings at the end of lines that were auto cleaned up. I can remove these updates if you prefer them to stay.