Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve next_pass documentation #9762

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Improve next_pass documentation #9762

merged 2 commits into from
Aug 28, 2024

Conversation

huwpascoe
Copy link
Contributor

No description provided.

@AThousandShips AThousandShips added topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement labels Aug 16, 2024
@AThousandShips AThousandShips requested a review from a team August 16, 2024 17:20
AThousandShips
AThousandShips reviewed Aug 16, 2024
View reviewed changes
tutorials/3d/standard_material_3d.rst Outdated Show resolved Hide resolved
tutorials/3d/standard_material_3d.rst Outdated Show resolved Hide resolved
tutorials/3d/standard_material_3d.rst Outdated Show resolved Hide resolved
tutorials/3d/standard_material_3d.rst Outdated Show resolved Hide resolved
clayjohn
clayjohn reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some spelling/grammar suggestions. Otherwise it looks good

tutorials/3d/standard_material_3d.rst Outdated Show resolved Hide resolved
tutorials/3d/standard_material_3d.rst Outdated Show resolved Hide resolved
tutorials/3d/standard_material_3d.rst Outdated Show resolved Hide resolved
@huwpascoe
Copy link
Contributor Author

All the grammatical errors are fixed I think.

Calinou
Calinou reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge after applying suggestions.

@Calinou
Copy link
Member

Calinou commented Aug 23, 2024 •
edited
Loading

Do you have the project files to generate that image? If so, could you upload it here as a ZIP for future reference? Thanks in advance 🙂

@huwpascoe huwpascoe force-pushed the next_pass branch 2 times, most recently from 4b6fcc2 to d0c66d0 Compare August 24, 2024 10:41
@huwpascoe
Copy link
Contributor Author

Here is source next_pass.zip (inkscape file)

Calinou
Calinou approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 586a2fd into godotengine:master Aug 28, 2024
1 check passed
mhilbrunner pushed a commit that referenced this pull request Oct 4, 2024
@huwpascoe @mhilbrunner
Improve next_pass documentation in Standard Material 3D (#9762)
619cea0
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn left review comments

@AThousandShips AThousandShips AThousandShips left review comments

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.2 enhancement topic:rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huwpascoe @Calinou @mhilbrunner @clayjohn @AThousandShips