Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove article before plural noun in autoloads_versus_internal_nodes.rst #9826

Closed
wants to merge 122 commits into from

Conversation

Lukas-Fletcher
Copy link
Contributor

A plural noun shouldn't be preceded by an indefinite article butte.edu/departments/cas/tipsheets/grammar/articles

@AThousandShips
Copy link
Member

You've started your branch from the wrong origin, to fix this use: git rebase -i --onto master 4.3, or create a new branch, making sure it starts from master, not 4.3

@AThousandShips AThousandShips added the needs work Needs additional work by the original author, someone else or in another repo. label Aug 24, 2024
Piralein and others added 28 commits August 24, 2024 19:31
Co-Authored-By: PoolloverNathan <24194027+PoolloverNathan@users.noreply.github.com>
Co-Authored-By: Solor Vox <1246172+solorvox@users.noreply.github.com>
Added Sickhead to porting studios.
Command used:

    lychee **/*.rst --github-token="..." --accept="100..=103,200..=299,429"

429 error codes were allowed due to a high number of false positives,
even with a GitHub token specified.
- Added xform and xform_inv's change to use * operator.
- Provided better details on the changes.
- Update the recommendation to check for the project running on
  a mobile web browser.
* Update first_look_at_the_editor.rst

add macOS shortcut and cleaning up the click shortcut.
* Update learning_new_features.rst

* Update getting_started/introduction/learning_new_features.rst

Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>

---------

Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-Authored-By: Bryan Gillis <7204836+brgillis@users.noreply.github.com>
Co-Authored-By: Clay John <claynjohn@gmail.com>
The `SetAction` and `SetPressed` are internal methods and can't be invoked directly outside of that assembly. However, the `Action` and `Pressed` property setters invoke them instead.
skyace65 and others added 22 commits August 24, 2024 19:32
Adds links to navigation mesh chunks demos.
The link on the live documentation was leading to a "Page not found" error.
This link also points to a 404
Mentions the new simplify_path  properties on the NavigationAgents.
Adds 2D versions of the NavigationAgent script templates and condenses all the templates in a tab menu.
Adds a tip to TileMap navigation section that informs users to prefer baking the TileMap navigation.
Also adds a warning that 2D navigation meshes can not overlap.
* Adding page about gdextension docs generation

---------

Co-authored-by: Max Hilbrunner <mhilbrunner@users.noreply.github.com>
…9618)

Although the tutorial assumed the hot reload feature, it wasn't enabled in the example config file. Also it didn't mention that it only works if it's compiled in debug mode.
…ss_name keyword/global class attribute (godotengine#9548)

* Added warning about Editor hiding class_names beginning with Editor prefix

---------

Co-authored-by: Max Hilbrunner <mhilbrunner@users.noreply.github.com>
…utter and input lag

This also documents command line arguments that may be of interest when
running Godot projects.
…header

Added/changed description of TIME in CanvasItem, Fog, Particle, Sky, and Spatial shader pages. Description now links to other relevant docs pages. Added a label to the global uniform header of shading_languge.rst, so it can be cross referenced from elsewhere.
@Lukas-Fletcher
Copy link
Contributor Author

Yeah I'm gonna need to create a new branch, my rebasing attempt did not work

@Lukas-Fletcher Lukas-Fletcher deleted the patch-1 branch August 24, 2024 17:35
@AThousandShips AThousandShips added archived and removed needs work Needs additional work by the original author, someone else or in another repo. labels Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

55 participants