Add missing manual renames from editor's renames_map #9849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
requested changes
Aug 27, 2024
AThousandShips
added
enhancement
discussion
area:manual
remove () from properties. removing duplicates. reorder
skyace65
added
cherrypick:4.0
cherrypick:4.1
cherrypick:4.2
cherrypick:4.3
and removed
cherrypick:4.0
labels
skyace65
force-pushed
the
patch-2
branch
2 times, most recently
from
82ad02b to
436c3c3
Compare
skyace65
approved these changes
Jan 24, 2025
|
I fixed the build issue and checked over some of the conversions, everything looks good to me. Thanks a ton for this work! And congrats on your first merged PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are manual methods from the editor's renames map. There are a few that are not included for various reasons, that are discussed in issue #9850.
If possible this should probably also be added to previous release branches.