Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to support 4.0.1 #178

Closed
wants to merge 3 commits into from
Closed

Conversation

finepointcgi
Copy link

@finepointcgi finepointcgi commented Apr 1, 2023

This should allow for support for 4.0.1 tested on Windows 11
Fixes #177

@Calinou Calinou added the bug label Apr 7, 2023
@Calinou
Copy link
Member

Calinou commented Apr 7, 2023

4.0.2 is now released, can you update this PR accordingly?

@finepointcgi
Copy link
Author

4.0.2 is now released, can you update this PR accordingly?

I will as soon as they tag which commit is the proper submodule commit for godot-cpp.
image

@Calinou
Copy link
Member

Calinou commented Apr 7, 2023

@finepointcgi
Copy link
Author

This should be updated to work with 4.0.3

@Faless
Copy link
Contributor

Faless commented Jun 27, 2023

This should not be needed, using the extension API of 4.0.0 should work with all 4.0.x versions.

On the other hand, using the extension API for 4.0.3, might end up causing issues in 4.0.0 (the extension API version basically defines the minimum supported version).

For 4.1.x we will need instead to update as GDExtension broke compatibility one last time to fix some memory issues (see godotengine/godot-cpp#1123).

We should then stop updating at 4.1.0 if we want compatibility with all 4.1+ godot versions.

@Arakade
Copy link

Arakade commented Sep 26, 2023

Tried using the built binaries from this with Godot 4.1.1 (Mono) and while it starts, the version control window is blank.
Forgive if this is known -- looking to use Godot with Git for Ludum Dare this weekend but seems 4.1.1 is a no go, right?

@Calinou
Copy link
Member

Calinou commented Sep 27, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not working in godot 4.0.2 rc1
5 participants