Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the LSP defined SymbolKind enum and fix marked #325

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

raulsntos
Copy link
Member

Since Godot uses the SymbolKind enum defined by the LSP protocol instead of the one defined by VSCode.
This enum was changed in Godot in godotengine/godot#50913 and was backported to 3.x in godotengine/godot#50914.

Also fixes marked being called incorrectly to parse codeblocks.

Fixes #321

Since Godot uses the `SymbolKind` enum defined by the LSP protocol
instead of the one defined by VSCode.

Also fixes `marked` being called incorrectly to parse codeblocks.
@Calinou Calinou added the bug label Feb 24, 2022
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 12858a2 into godotengine:master Feb 24, 2022
@raulsntos raulsntos deleted the fix-lsp-symbolkind branch February 24, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing properties, methods and signals in "List Native Classes in Godot"
2 participants