Add strict onEnterRules for controlling indentation #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Apr 7, 2022
Calinou
reviewed
Apr 7, 2022
only the second rule is needed for the godotengine#337 to be solved
…t-vscode-plugin into indentation-rules
|
Just to make sure, is this good to merge now? |
|
@Calinou Please see the behavior on the gif below. Adding indentation by just pressing Enter works as before. The problem I'm having with this is that I can't explain why it fixes the issue, so if someone is willing to test this config as well, as I have only one environment to test on, it would be better. |
|
This is a big improvement over the previous behavior. |
Calinou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugsquad edit: This closes #337.