Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operator syntax highlighting when next to an opening parenthesis #375

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Fix operator syntax highlighting when next to an opening parenthesis #375

merged 2 commits into from
Jun 2, 2022

Conversation

oidro
Copy link
Contributor

@oidro oidro commented Jun 2, 2022 •
edited
Loading

This PR fixes the highlighting of the logic operators "or," "not," and "and" when used next to opening parenthesis.

Before:
image

After:
image

This is related to #353.

oidro added 2 commits June 2, 2022 15:54
@oidro
Fix logic operator highlighting
8af5827
@oidro
Improve placement of include
ed57d64 
Make logic_op a part of base_expression, rather than adding a new pattern to another rule.
@Calinou Calinou added the bug label Jun 2, 2022
Calinou
Calinou approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou changed the title Fix operator highlighting Fix operator syntax highlighting when next to an opening parenthesis Jun 2, 2022
@Calinou Calinou merged commit 94e5a9e into godotengine:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oidro @Calinou