Syntax highlighting changes #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new annotation should probably be in a separate PR that depends on godotengine/godot#82987 being merged. The other two seems great for consistency. |
ryanabx
force-pushed
the
syntax/highlighting-changes
branch
2 times, most recently
from
956dc99 to
23557f0
Compare
No, there's no reason to push that out to another PR. Adding and removing annotations is a trivial change, and the linked engine PR seems quite likely to get merged. The grammar in this extension is explicitly attempting to be a superset of all versions of GDScript, so adding support for future features is just as valid as maintaining support for Godot 3 features or features that were deprecated and removed. |
ryanabx
force-pushed
the
syntax/highlighting-changes
branch
from
23557f0 to
00a7f9c
Compare
Better syntax highlighting for properties. Class variables used to be unhighlighted and are now highlighted properly as `variable.other.gdscript`, properties are still highlighted as `variable.other.property.gdscript`
ryanabx
force-pushed
the
syntax/highlighting-changes
branch
from
00a7f9c to
211fbf3
Compare
|
Sorry for the delay. Everything looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abstractannotation Implement abstract methods in GDScript godot#82987 (4.3) to the list of annotations in the gdscript textmate grammar.will move to a new PRnvm.properties) and are now highlighted properly asvariable.other.property.gdscriptvoidas akeywordinstead of aclass. See https://github.com/godotengine/godot/blob/a574c0296b38d5f786f249b12e6251e562c528cc/modules/gdscript/gdscript_tokenizer.h#L130C4-L130C8 (gdscript considersvoidto be a keyword, similar to C-style languages)NOTE: This is my first time working with regular expressions, so please let me know if I've made a mistake with my added regular expressions!
Before:
After:
