Adjust Godot version detection regex #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version detection would fail to detect some versions of godot (e.g 4.1.1.stable.mono.official.bd6af8e0e), resulting in an unclear error message. This commit makes a minor change to slightly improve the robustness of the version detection regex. Signed-off-by: mlsvrts <mlsvrts@protonmail.com>
|
Thanks for catching that, and congrats on your first contribution! |
No problem! I was very happy to find that, besides this small issue, the debugger upgrade has made Godot 4 debugging integration very painless; thanks for your work on it! |
DaelonSuzuka
changed the title
That's great to hear! There's more work to do, but it should way more stable and reliable than before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version detection would fail to detect some versions of godot (e.g 4.1.1.stable.mono.official.bd6af8e0e), resulting in an unclear error message. This commit makes a minor change to slightly improve the robustness of the version detection regex.
With this change I can run and debug my project with godot 4.1.1, and breakpoints even work 😄