Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BBCode [br] not rendering in hover #557

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

DeszkaCodes
Copy link
Contributor

Fixes the issue of [br] bbcode's weren't rendering new lines.

@DaelonSuzuka
Copy link
Collaborator

Can you share some examples of where that happens so I can validate the behavior + the fix?

@DeszkaCodes
Copy link
Contributor Author

Can you share some examples of where that happens so I can validate the behavior + the fix?

Of course.

This happened every time I added "##" documentations to functions and hovered over them. [br] tags rendered like they were inside a [code] tag.

For example:

## A test function. [br]
## Testing.
func test():
    return true

Rendered hover documentation like:
"A test function. br Testing."

While the expected behaviour is:
"""
A test function.
Testing.
"""

@DaelonSuzuka
Copy link
Collaborator

Oh, I get it. I didn't notice at first that you were adding the [br] tag, I was trying to think of why the language server would send bbcode line breaks and I was very confused.

Are you doing that to work around the fact that Godot 4 seems to not separate multiple lines of doc comments?

image

@Calinou @ryanabx Is this a bug in the G4 language server? G3 returns doc comments without concatenating them:

image

@DeszkaCodes
Copy link
Contributor Author

Are you doing that to work around the fact that Godot 4 seems to not separate multiple lines of doc comments?

Yep, that's what I meant to fix somehow.

@DaelonSuzuka
Copy link
Collaborator

@DeszkaCodes Thanks for your contribution, and congrats on getting your first PR merged here!

@DaelonSuzuka DaelonSuzuka merged commit 7462f88 into godotengine:master Dec 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants