Fix poor documentation formatting of class titles and inheritance chain #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the extended inheritence chain previously being parsed is no longer available, which causes the "Inherits: " information to be empty. Inspecting the symbol information available, it seems there is no way to recover the inheritence chain without additional queries or modifying LSP response, so a quick fix to display the correct information that we do have is an incremental improvement.
|
@jogly Thanks for catching this and for the quick fix. |
DaelonSuzuka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the extended inheritance chain previously being parsed is no longer available, which causes the "Inherits: " information to be empty. Inspecting the symbol information available, it seems there is no way to recover the inheritance chain without additional queries or modifying LSP response, so a quick fix to display the correct information that we do have is an incremental improvement.
Before
After
