Improve codeblock formatting in documentation #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves codeblock highlighting by:
- Adding context to the codeblock detailing which language the
following code is.
- Setting the `pre` block's background to match the default
background for `code` blocks to give a consistent experience.
- Setting a border radius for the `pre` block double that of the
`code` block's default (4px, which is hard-coded).
|
That's awesome, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves codeblock highlighting by:
preblock's background to match the default background forcodeblocks to give a consistent experience.preblock double that of thecodeblock's default (4px, which is hard-coded).Works on class documentation blocks and
licode blocks for properties/members/methods.Before
After